General optimizations around Persisters for simplicity and sanity of us all. #1246
Conversation
|
Hello, thank you for creating this pull request. I have automatically opened an issue http://www.doctrine-project.org/jira/browse/DDC-3487 We use Jira to track the state of pull requests and the versions they got |
| foreach ($diff as $element) { | ||
| $this->conn->executeUpdate($sql, $this->getInsertRowSQLParameters($coll, $element)); | ||
| } | ||
| throw new \BadMethodCallException("Deleting elements is not supported by this CollectionPersister."); |
There was a problem hiding this comment.
Make the method abstract instead?
guilhermeblanco
changed the title
…, fixed docblock return value hint
…iable overwrite more obvious
|
@guilhermeblanco merged, thanks!
|
| * Gets the SQL parameters for the corresponding SQL statement to delete the given | ||
| * element from the given collection. | ||
| * | ||
| * @internal Order of the parameters must be the same as the order of the columns in getDeleteRowSql. |
There was a problem hiding this comment.
This should not be documented this way. It is a usage of @internal which does not match the phpdoc standards. @internal is about marking a method as being internal, not about providing advanced documentation which should be hidden while other parts are visible
There was a problem hiding this comment.
I'll have another run at all @internal docblocks later, as it is indeed getting annoying in IDEs :-)
There was a problem hiding this comment.
Btw, this cleanup has been done in DBAL a while ago
No description provided.