Fixed issue when paginator orders by a subselect expression #1463
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rms supporting ROW_NUMBER OVER() function.
|
Hello, thank you for creating this pull request. I have automatically opened an issue http://www.doctrine-project.org/jira/browse/DDC-3831 We use Jira to track the state of pull requests and the versions they got |
|
I think the coverage drop is down to the change not running under SQLite. Running the tests under postgres, this change is definitely covered. |
|
@Ehimen that's alright, we should rather merge the coverage in future. Thanks! |
| @@ -1093,6 +1093,10 @@ public function walkOrderByItem($orderByItem) | |||
|
|
|||
| $this->orderedColumnsMap[$sql] = $type; | |||
|
|
|||
| if ($expr instanceof Query\AST\Subselect) { | |||
| $sql = "($sql)"; | |||
There was a problem hiding this comment.
Use explicit string concatenation here, please. Eventually simply return early
…ression fix; syntax fixes.
|
Thanks @Ocramius! I've updated with some changes. Are these what you had in mind? |
billschaller
pushed a commit
that referenced
this pull request
Aug 4, 2015
Fixed issue when paginator orders by a subselect expression
billschaller
pushed a commit
that referenced
this pull request
Aug 4, 2015
Fixed issue when paginator orders by a subselect expression Conflicts: tests/Doctrine/Tests/ORM/Tools/Pagination/LimitSubqueryOutputWalkerTest.php
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On platforms that support the ROW_NUMBER() OVER() function, we've found issues when ordering by a subselect expression. Have included a test demonstrating the problem that was failing with a syntax error under Postgres: