Make exception message configurable for NoResultException #1484
Conversation
Currently it's not possible to use a custom exception message for the NoResultException. It would be great to use a custom one. For example you can define what specific result was expected or with what query it was executed, let's say you want to find members with a select query. Then it would be great if the message could be 'No members found for query.', instead of the default message. This change is backward compatible, because it checks for emptiness of the message, and only if it's not empty it uses the custom message. Furthermore it's now possible to loop the parameters $code and $prevision exception throw this NoResultException.
|
Hello, thank you for creating this pull request. I have automatically opened an issue http://www.doctrine-project.org/jira/browse/DDC-3856 We use Jira to track the state of pull requests and the versions they got |
| */ | ||
| public function __construct() | ||
| public function __construct($message = '', $code = 0, \Exception $previous = null) |
There was a problem hiding this comment.
Why not just add $message = 'No result was found for query although at least one row was expected.', here instead of checks in the constructor body?
There was a problem hiding this comment.
Sure. this is the best and most simple solution.
|
I don't see a reason to change this, since this exception should only be thrown from the internal scope. |
|
While I understand that you have your own use-case for customizing the exception message, you should instead use your own exception class/interface rather than relying on the ORM ones. This is indeed a limitation caused by the ORM not having proper exception marker interfaces right now ( doctrine/common#681 ) |
Currently it's not possible to use a custom exception message for the NoResultException. It would be great to use a custom one. For example you can define what specific result was expected or with what query it was executed, let's say you want to find members with a select query. Then it would be great if the message could be 'No members found for query.', instead of the default message.
This change is backward compatible, because it uses the current message as default value for message. Furthermore it's now possible to loop the parameters $code and $prevision exception throw this NoResultException.
Thanks for the hint Koc.