Update DateTime cookbook code #1497
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It seems that existing code was outdated and lacked ``use`` statement in order to work correctly. We also added instructions on how to configure the new type, since it may not be straightforward for newcomers.
|
Hello, thank you for creating this pull request. I have automatically opened an issue http://www.doctrine-project.org/jira/browse/DDC-3882 We use Jira to track the state of pull requests and the versions they got |
|
|
||
| .. code-block:: yml | ||
|
|
||
| doctrine: |
There was a problem hiding this comment.
This is symfony-specific documentation that shouldn't land inside the ORM documentation
Ocramius
added a commit
that referenced
this pull request
Dec 11, 2015
Ocramius
added a commit
that referenced
this pull request
Dec 11, 2015
Highly performance sensitive code should avoid method calls, sadly
Ocramius
added a commit
that referenced
this pull request
Dec 11, 2015
Ocramius
added a commit
that referenced
this pull request
Dec 11, 2015
|
@PowerKiKi applied few changes (mainly removed the private static method - sadly relevant in performance-sensitive code) and merged, thanks! |
|
Thanks for merging and feedback ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It seems that existing code was outdated and lacked
usestatement in order to work correctly.We also added instructions on how to configure the new type, since it may not be straightforward for newcomers.