[RFC] Tests around reported cases over DDC-2524 #1570
Conversation
|
Hello, thank you for creating this pull request. I have automatically opened an issue http://www.doctrine-project.org/jira/browse/DDC-4018 We use Jira to track the state of pull requests and the versions they got |
guilhermeblanco
changed the title
|
@mnapoli so far I fixed the |
guilhermeblanco
force-pushed
the
DDC-2524
branch
from
b1d540f
to
4d337f1
Compare
guilhermeblanco
changed the title
guilhermeblanco
force-pushed
the
DDC-2524
branch
from
4d337f1
to
8ea62b9
Compare
[RFC] Tests around reported cases over DDC-2524
| */ | ||
| public function addClass($class) |
There was a problem hiding this comment.
removing public properties is a BC break, which must not be done in minor releases. You broke doctrine/data-fixtures. Please add the methods back
There was a problem hiding this comment.
Agree here - the merge has to be reverted and delayed to 3.x :-(
There was a problem hiding this comment.
This class was never meant to be used by anyone else, not even other Doctrine projects.
data-fixtures should copy the new class and use on its own
There was a problem hiding this comment.
Here is a more detailed reason why I think this should not be reverted and why data-fixtures usage of the old class here is broken: doctrine/data-fixtures#212 (comment)
There was a problem hiding this comment.
A solution as been decided for this BC break ? We temporarily fix the Doctrine ORM version to 2.5.2 on our project.
There was a problem hiding this comment.
@fsevestre yes, we'll not revert this commit. Explanation is available at data-fixtures comment I left in previous message.
There was a problem hiding this comment.
@guilhermeblanco Does that mean this fix will land in the next 2.5.x release?
I've got a different issue with commit ordering that this PR solves, so I really need it soon.
There was a problem hiding this comment.
Upon further review, it looks like my issue is likely related to cyclic dependencies, which explains why this fix would solve my issue.
There was a problem hiding this comment.
It'll only land in 2.6, as this introduces a BC break for data-fixtures project.
Fixes #707