Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove dead code SQLWalker::walkCaseExpression #5600

Merged

Conversation

billschaller
Copy link
Member

SQLWalker::walkCaseExpression seems to be a do-nothing method. Nothing calls it in the ORM or any library I can find, and it is essentially the same as just calling $expression->dispatch($walker). It's just sitting there lowering our test coverage and being silly.

@billschaller billschaller added this to the 2.6.0 milestone Jan 8, 2016
Copy link
Member

@lcobucci lcobucci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but maybe we should update the documentation to add it as a minor BC break, what do you think @Ocramius?

@Ocramius Ocramius self-assigned this Jan 15, 2017
@Ocramius Ocramius merged commit 09cbb9f into doctrine:master Jan 15, 2017
@Ocramius
Copy link
Member

@lcobucci aye, doing so on master now.

@Ocramius
Copy link
Member

Done so in 41a3779

Ocramius added a commit that referenced this pull request Jan 15, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants