Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding a note about the `Doctrine\ORM\QueryBuilder#addCriteria()` method #6257

Merged
merged 1 commit into from Jan 25, 2017

Conversation

@weaverryan
Copy link
Contributor

weaverryan commented Jan 25, 2017

Hi guys!

Just adding a note to connect things better.

Thanks!

@Ocramius Ocramius self-assigned this Jan 25, 2017
@Ocramius Ocramius added this to the 2.6.0 milestone Jan 25, 2017
@Ocramius

This comment has been minimized.

Copy link
Member

Ocramius commented Jan 25, 2017

👍 thanks @weaverryan

Filtering Collections
---------------------

.. filtering-collections:

This comment has been minimized.

Copy link
@weaverryan

weaverryan Jan 25, 2017

Author Contributor

I believe the _ was left off accidentally before - I'm not familiar with this syntax without an underscore, and I searched the codebase and found NO other references like this (git grep '\.\. ' | grep -v 'code-block' | grep -v 'note' | grep -v 'section' | grep -v '\.\. _' | grep -v 'configuration-block' | grep -v versionadded | grep -v 'warning' | grep -v '//' | grep -v '\-\->' | grep -v 'include' | grep -v 'caution' | less gets you a short list, where you can see this). Also, this section header already gave us a #filtering-collections anchor, even without the added reference.

@Ocramius Ocramius changed the title [Docs] Adding a note about the addCriteria method on QueryBuilder Adding a note about the `Doctrine\ORM\QueryBuilder#addCriteria()` method Jan 25, 2017
@Ocramius Ocramius merged commit 888f1be into doctrine:master Jan 25, 2017
0 of 2 checks passed
0 of 2 checks passed
Scrutinizer Running
Details
continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
@weaverryan weaverryan deleted the weaverryan:add-criteria-note branch Jan 25, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.