Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tests: Return types for setUp, tearDown and all test methods #7122

Merged
merged 1 commit into from
Mar 9, 2018
Merged

Tests: Return types for setUp, tearDown and all test methods #7122

merged 1 commit into from
Mar 9, 2018

Conversation

Majkl578
Copy link
Contributor

@Majkl578 Majkl578 commented Mar 8, 2018 •
edited
Loading

(\S+ function (?:setUp|tearDown|test\w+\([^)]*\)))$ -> $1 : void

  • some manual fixes for dependent non-void tests.

further scope in upcoming PRs:

  • native return types for other methods
  • native parameter types

@Majkl578 Majkl578 added this to the 3.0 milestone Mar 8, 2018
carusogabriel
carusogabriel approved these changes Mar 8, 2018
View reviewed changes
Copy link
Contributor

@carusogabriel carusogabriel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 for this step in use return types

@Ocramius Ocramius self-assigned this Mar 9, 2018
Ocramius
Ocramius approved these changes Mar 9, 2018
View reviewed changes
Copy link
Member

@Ocramius Ocramius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@Ocramius Ocramius merged commit 43c2524 into doctrine:master Mar 9, 2018
@Majkl578 Majkl578 deleted the dev/tests/typing-setup-teardown-tests branch March 9, 2018 16:15
@greg0ire greg0ire added this to To consider 🤔 in Backports via automation Jun 27, 2021
@greg0ire greg0ire removed this from the 3.0.0 milestone Jun 27, 2021
@beberlei beberlei moved this from To consider 🤔 to Rejected 👎 in Backports Jul 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ocramius Ocramius Ocramius approved these changes

@carusogabriel carusogabriel carusogabriel approved these changes

Assignees

@Ocramius Ocramius

Labels
Improvement
Projects
Backports
  
Rejected 👎
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@Majkl578 @Ocramius @carusogabriel @greg0ire