Fix #7286: StringPrimary no longer accepts aggregate functions as argument #7296
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Ocramius any thoughts here? |
|
@lcobucci Added |
|
Bah, fails on Postgres, would have to test with pre-2.6 to see what worked or not. |
|
@Majkl578 that's exactly what I meant, thanks for adding the test 👍 |
lcobucci
approved these changes
Jul 9, 2018
|
@Majkl578 can you please port it to 3.0-dev? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
866418e (#6500) removed special-casing of aggregate functions.
This was mostly transparent for cases where
isAggregateFunction()is used, but not in StringPrimary which doesn't useisAggregateFunction()to detect the function ahead.Since these functions (still) have separate tokens, they're not recognized as T_IDENTIFIER in StringPrimary, thus not handled as generic FunctionDeclaration.
Fixes #7286.