Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GH-4641] IDENTITY() field type conversion #8025

Open
wants to merge 4 commits into
base: 2.17.x
Choose a base branch
from

Conversation

beberlei
Copy link
Member

This fixes a bug with a missing type conversion for IDENTITY() function values and data was always returned with type "string". Now the specified type is used and the new typed function node functionality #7941 allows converting it to the real PHP type.

Fixes #4641

@beberlei beberlei changed the base branch from 2.8.x to 2.17.x October 22, 2023 20:04
Copy link
Member

@lcobucci lcobucci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes LGTM, I'm just unsure if we have tests covering both paths ($this->fieldMapping === null and $this->fieldMapping !== null)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants