Documenting interface methods (based on entity manager) #870
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello, thank you for creating this pull request. I have automatically opened an issue http://www.doctrine-project.org/jira/browse/DDC-2846 We use Jira to track the state of pull requests and the versions they got |
| * | ||
| * @param string $dql The DQL string. | ||
| * | ||
| * @return \Doctrine\ORM\Query |
|
Also: if these docblocks are extracted from the EntityManager, can we get rid of them in the implementation by using |
|
Perfect @Ocramius, I'll do that changes. |
|
@Ocramius, I'll add the |
|
@lcobucci should be ok if they are 100% the same |
|
Done ;) |
Ocramius
added a commit
that referenced
this pull request
Dec 10, 2013
Documenting interface methods (based on entity manager)
|
@Ocramius could you please merge this to branch |
This was referenced Dec 6, 2015
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.