Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Try running unit tests on HHVM #873

Merged
merged 1 commit into from
Dec 13, 2013
Merged

Try running unit tests on HHVM #873

merged 1 commit into from
Dec 13, 2013

Conversation

ptarjan
Copy link
Contributor

@ptarjan ptarjan commented Dec 13, 2013

No description provided.

@doctrinebot
Copy link

Hello,

thank you for creating this pull request. I have automatically opened an issue
on our Jira Bug Tracker for you. See the issue link:

http://www.doctrine-project.org/jira/browse/DDC-2853

We use Jira to track the state of pull requests and the versions they got
included in.

beberlei added a commit that referenced this pull request Dec 13, 2013
@beberlei beberlei merged commit b6a0c8b into doctrine:master Dec 13, 2013
@stof
Copy link
Member

stof commented Dec 14, 2013

I would mark it as allowed failure for now, to avoid having broken builds all the time until the HHVM support is working (otherwise people will take the habit to ignore the build status)

@Majkl578
Copy link
Contributor

@stof: Agreed, just add the following:

matrix:
    allow_failures:
        - php: hhvm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants