Parser: SimpleArithmeticExpression should return ArithmeticTerm

[janbarasek]

Bugfix of return type error.

The SimpleArithmeticExpression() method can also return an ArithmeticTerm type that is not defined in the annotation.

Example:

[derrabus]

Can you please update the baselines of Psalm and PHPStan?

[janbarasek]

@derrabus I tried to fix the baseline. Please enable the tests. Thank you.

[derrabus]

Both baselines are generated files. Don't edit them manually.

./vendor/bin/phpstan --generate-baseline
./vendor/bin/psalm --no-cache --set-baseline=psalm-baseline.xml

[janbarasek]

I successfully updated the Psalm baseline and PhpStan did not need to make any changes:

[derrabus]

Sorry for the trouble with our tooling. But fixing doc blocks in most cases means that static analysis will report less different errors, so we have to review and adjust the baselines.

Your fix is certainly correct. I've reviewed the return types on Parser and some AST classes recently and found a lot more inaccurate annotations. If you continue to work with the parser, please take all annotations with a grain of salt. 😕