Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Widen types for DiscriminatorMap #9922

Merged
merged 2 commits into from
Jul 21, 2022
Merged

Widen types for DiscriminatorMap #9922

merged 2 commits into from
Jul 21, 2022

Conversation

derrabus
Copy link
Member

@derrabus derrabus commented Jul 20, 2022 •
edited

Fixes #9921

  • Discriminator values may be integers
  • The annotation does not require the entity classes to be valid FQCNs. If both entities are in the same namespace, the short name suffices.

@derrabus derrabus added this to the 2.12.4 milestone Jul 20, 2022
@derrabus derrabus requested a review from greg0ire July 20, 2022 21:16
@derrabus derrabus changed the title Allow integers as keys for DiscriminatorMap Widen types for DiscriminatorMap Jul 20, 2022
@derrabus derrabus merged commit faedb90 into doctrine:2.12.x Jul 21, 2022
@derrabus derrabus deleted the bugfix/int-descr-map branch July 21, 2022 08:19
derrabus added a commit to derrabus/orm that referenced this pull request Jul 25, 2022
@derrabus
Merge branch '2.13.x' into 3.0.x
5830736 
* 2.13.x:
  Add helper function TreeWalkerAdapter::getMetadataForDqlAlias() (doctrine#9932)
  Simplify LanguageRecognitionTest (doctrine#9930)
  test/added test for foreign keys with custom id object types
  Widen types for DiscriminatorMap (doctrine#9922)
  schema tool: remove useless text from --dump-sql output
  Update IdentifierFlattener.php
  Update IdentifierFlattener.php
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@greg0ire greg0ire greg0ire approved these changes

Assignees
No one assigned
Labels
Static Analysis
Projects
None yet
Milestone
2.12.4
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@derrabus @greg0ire