Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify LanguageRecognitionTest #9930

Merged

Conversation

derrabus
Copy link
Member

PHPUnit is pretty good at catching exceptions and printing stack traces, so we don't have to do that.

@derrabus derrabus added this to the 2.12.4 milestone Jul 25, 2022
@derrabus derrabus requested a review from greg0ire July 25, 2022 13:20
@derrabus derrabus changed the title Simplify LanguageRecognitionTest Simplify LanguageRecognitionTest Jul 25, 2022
@derrabus derrabus merged commit 6c64bc6 into doctrine:2.12.x Jul 25, 2022
@derrabus derrabus deleted the improvement/language-recognition-test branch July 25, 2022 14:14
derrabus added a commit to derrabus/orm that referenced this pull request Jul 25, 2022
* 2.13.x:
  Add helper function TreeWalkerAdapter::getMetadataForDqlAlias() (doctrine#9932)
  Simplify LanguageRecognitionTest (doctrine#9930)
  test/added test for foreign keys with custom id object types
  Widen types for DiscriminatorMap (doctrine#9922)
  schema tool: remove useless text from --dump-sql output
  Update IdentifierFlattener.php
  Update IdentifierFlattener.php
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants