remove obsolete method, added a todo

CHANGELOG.md

@@ -1,6 +1,13 @@
 Changelog
 =========
 
+2013-01-18
+----------
+
+ * Removed DocumentRepository->getDocumentsByQuery as it is no longer needed.
+   createQuery returns you an ODM query that can find documents directly.
+   To get documents from a PHPCR query there is DocumentManager->getDocumentsByPhpcrQuery()
+
 2013-01-13
 ----------
 

lib/Doctrine/ODM/PHPCR/DocumentRepository.php

@@ -240,10 +240,12 @@ public function escapeFullText($string)
      * @param  string $statement the SQL2 statement
      * @param  string $language (see QueryInterface for list of supported types)
      * @param  bool $replaceWithFieldnames if * should be replaced with Fieldnames automatically
-     * @return PHPCR\Query\QueryResultInterface
+     *
+     * @return Query
      */
     public function createQuery($statement, $language, $options = 0)
     {
+        // TODO: refactor this to use the odm query builder
         $qb = $this->dm->createPhpcrQueryBuilder()->setFromQuery($statement, $language);
         if ($options & self::QUERY_REPLACE_WITH_FIELDNAMES) {
             $columns = $qb->getColumns();
@@ -269,17 +271,6 @@ public function createQuery($statement, $language, $options = 0)
         return new Query($qb->getQuery(), $this->getDocumentManager());
     }
 
-    /**
-     * Get documents from a PHPCR query instance
-     *
-     * @param  \PHPCR\Query\QueryResultInterface $result
-     * @return array of document instances
-     */
-    public function getDocumentsByQuery(\PHPCR\Query\QueryInterface $query)
-    {
-        return $this->dm->getDocumentsByQuery($query, $this->className);
-    }
-
     /**
      * Create a QueryBuilder that is prepopulated for this repositories document
      *