when replacing children having children of their own, things fail #262
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -588,6 +588,10 @@ public function persist($document) | |||
| throw new \InvalidArgumentException('Parameter $document needs to be an object, '.gettype($document).' given'); | |||
| } | |||
|
|
|||
| if (UnitOfWork::STATE_MANAGED === $this->unitOfWork->getDocumentState($document)) { | |||
| return; | |||
There was a problem hiding this comment.
this causes CascadePersistTest::testCascadePersistForManagedEntity to fail. i would have expected that the new children automatically get persisted, without needing to call persist again.
There was a problem hiding this comment.
ok, whatever else we do, this is wrong as we diverge from the logic of what orm is doing in this case.
6 tasks
|
do we still consider this a blocker for a stable 1.0 release? or can we consider this a known bug and go stable without solving it? |
|
i will close, the branch is backuped on my own fork. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this is a WIP with failing tests and some tentative fixes that seem to be wrong.
see https://github.com/symfony-cmf/symfony-cmf/wiki/PHPCR-ODM-replace-document for a proposal how to actually solve the problems.
This needs hacks for example in the BlockBundle\Document\ImagineBlock::setImage