make Property an annotation, instead of adding new annotaiton Field #651
Conversation
dbu
force-pushed
the
property-vs-field
branch
2 times, most recently
from
efff044
to
2fada9d
Compare
| @@ -19,12 +19,8 @@ | |||
|
|
|||
| namespace Doctrine\ODM\PHPCR\Mapping\Annotations; | |||
| /** | |||
| * Base class for all the translatable properties (i.e. every property but Uuid and Version) | |||
| * @deprecated Use Property instead | |||
| */ | |||
| class TranslatableProperty extends Property | |||
There was a problem hiding this comment.
keeping for BC in case somebody extended it or has custom code that typechecks.
|
Changelog also needs to be updated |
|
tests failing due to |
|
ups. fixed, and tests where green. now updated the changelog. @dantleech @wouterj @lsmith77 ok with going like this? if so, i will update the doc as well. |
|
+1 from me |
|
I'm -1 on this change, but as it's 3 vs 1, I think I have no option... It's inconsistent with yaml, mongodb odm and couchdb odm. Also, it's a BC break for people having a custom annotation extending from Property (it know suddently becomes translatable, while the function of Property was to have something that's not translatable). |
|
oh, so mongodb and couchdb use Field? that would indeed be a strong argument in favor of using Field here as well. loosk like: http://doctrine-couchdb.readthedocs.org/en/latest/reference/basic-mapping.html#field-mapping so i am 👎 on my own PR :-/ |
|
alright .. then i will reactivate my docs PR to remove |
see doctrine/phpcr-odm-documentation#74
we need no BC for
@Fieldas it was never released.while doing this, i noticed that in yml mapping, the list of properties is called
fieldswhich would be an argument in favour of using@Fieldafter all. but@Propertyseems more natural for the annotations for me.