Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Update requirements & tests manual #840

Closed
wants to merge 2 commits into from

Conversation

scyzoryck
Copy link

Hello!
My first PR here. I made some small improvements to the setup documentation.
However, I might need some help with Running the tests section - After running tests/script_jackrabbit.sh it fails on the step of missing composer dependencies.

Best, scyzoryck.

Copy link
Member

@dbu dbu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks a lot for the cleanup! seems we forgot about the documentation when we moved away from travis-ci.

tests/script_jackrabbit.sh Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
@scyzoryck
Copy link
Author

Thanks @dbu for suggestions! I rewrote a bit section about setting up package for tests based on the commands from Github actions. :) Do you have some time for another look, please?

@scyzoryck scyzoryck requested a review from dbu April 27, 2023 14:34
README.md Outdated Show resolved Hide resolved
@dbu
Copy link
Member

dbu commented Apr 30, 2023

i realized that the documentation will be easier to read when explaining by implementation each step, rather than each step for each implementation. i reformatted it in #842

thanks to your work, this was quite easy to do now as you collected the necessary information and steps. thanks a lot!

@dbu dbu closed this Apr 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants