Infer parameters. Fixes #51 #157
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This uses the AST to add (untyped) params where they aren't explicitly specified. Would love to infer types here as well, but espree doesn't support them yet. cc @anandthakker / @jfirebaugh for the review
|
|
||
| // Ensure that explicitly specified parameters are not overridden | ||
| // by inferred parameters | ||
| var existingParams = comment.tags.filter(function (tag) { |
There was a problem hiding this comment.
Use comment.params here to avoid the filter.
|
Gotcha, done. Now only deals with comment.params. |
Closed
rhendric
pushed a commit
to rhendric/documentation
that referenced
this pull request
Sep 15, 2022
…umentationjs#160) * Update compiler solvable type classes, Fixes documentationjs#157 * Update Type-Classes.md * Remove ConsSymbol and descriptions * Change class -> classes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This uses the AST to add (untyped) params where they aren't explicitly
specified.
Would love to infer types here as well, but espree doesn't support
them yet.
cc @anandthakker / @jfirebaugh for the review