Refactor commands into modules #277
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
December 6, 2015 18:12
Arg parsing is now split into common options (in bin/documentation.js) and command-specific options (in each command module, exported as parseArgs). This includes moving `--private` and `--github` to the common args instead of having them under the build/serve commands. Reason: these two args are options understood by the main module, as opposed to args like `--format` which are only understood by the actual output piece in build/serve. Also removes `args.js`, which had previously exported the argument parsing for use in situations like documentation-readme. The need for this, I think, is largely made irrelevant in the face of slightly generalizing the CLI to use commands.
|
👍 want to merge this PR now and do #261 in another pass? |
|
@tmcw Yeah, I think that makes sense. Merging. |
anandthakker
added a commit
that referenced
this pull request
Dec 7, 2015
Refactor commands into modules
rhendric
pushed a commit
to rhendric/documentation
that referenced
this pull request
Sep 15, 2022
…tationjs#277) This reverts commit 25aa94a.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prepares for #261
See the note in the commit message for 5c8459d
@tmcw @jfirebaugh The refactoring here should be good to go. If you're 👍 on this then I can also go ahead and do #261 as part of this PR.