only auto-cleanup jobs if they return '201 Created'

documentcloud · Oct 5, 2009 · dd0a06e · dd0a06e
1 parent 3c628be
commit dd0a06e
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 1 deletion.
diff --git a/lib/cloud_crowd/models/job.rb b/lib/cloud_crowd/models/job.rb
@@ -55,9 +55,13 @@ def set_next_status
     # completion. The <tt>callback_url</tt> may include HTTP basic authentication,
     # if you like:
     #   http://user:password@example.com/job_complete
+    # If the callback URL returns a '201 Created' HTTP status code, CloudCrowd 
+    # will assume that the resource has been successfully created, and the Job
+    # will be cleaned up.
     def fire_callback
       begin
-        RestClient.post(callback_url, {:job => self.to_json})
+        response = RestClient.post(callback_url, {:job => self.to_json})
+        Thread.new { self.destroy } if response && response.code == 201
       rescue RestClient::Exception => e
         puts "Failed to fire job callback. Hmmm, what should happen here?"
       end

diff --git a/wiki/change_log.textile b/wiki/change_log.textile
@@ -1,3 +1,7 @@
+h3. Version 0.2.6
+
+* Jobs are now automatically cleaned up only if the callback_url returns a '201 Created' HTTP status code (Previously, any 200-range code would cause a cleanup).
+
 h3. Version 0.2.5
 
 * Bugfix for PostgreSQL databases regarding WorkUnit reservation.