Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exception::Class was not removed completly #5

Closed
jplesnik opened this issue Feb 10, 2016 · 5 comments
Closed

Exception::Class was not removed completly #5

jplesnik opened this issue Feb 10, 2016 · 5 comments

Comments

@jplesnik
Copy link

The Exception::Class is still used in Config::Model::Warper

lib/Config/Model/Warper.pm:
L569: if ( my $e = Exception::Class->caught($expected_error) ) {

Is it correct or should it be replaced?

@dod38fr
Copy link
Owner

dod38fr commented Feb 10, 2016

Oops... It should be replaced.

Thanks for the heads-up

@dod38fr
Copy link
Owner

dod38fr commented Feb 11, 2016

@jplesnik I'd like to know how you found this issue. Was it by reading code or did you get an error ?

All the best

@jplesnik
Copy link
Author

I was updating Fedora package to the latest version. Before I removed Exception::Class from build-requires, I just checked via grep if Exception::Class is no using in code.
I did not get any error.

@dod38fr
Copy link
Owner

dod38fr commented Feb 11, 2016

Interesting. I did not know that Config::Model was now up-to-date on Fedora. That's very good news. 😃

I'll fix this issue asap (I need to check whether this code is dead or not).

BTW, feel free to ask for changes that may ease your work as Fedora packager (As Debian packager, I know that upstream can help a lot in our day-to-day activities)

All the best

dod38fr added a commit that referenced this issue Feb 12, 2016
  YAML backend changes:
    * Remove YAML file when no data is left
    * When a root class has only one element, the backend
      write (and read) only the content of that element (this
      reduce the depth of the written data structure by one).

  Functional improvements:
    * Added "ChangeTracker" log class and traces (Log::Log4Perl)
    * HashId: load_data can load ordered data in non-ordered hash

  Bug fixes:
    * Removed Exception::Class from warper error handler
      (gh #5, Thanks jplesnik)
    * Dumper/Loader: handle literal \\n
@dod38fr
Copy link
Owner

dod38fr commented Feb 12, 2016

Fixed in v2.079

@dod38fr dod38fr closed this as completed Feb 12, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants