sanitize submission result #1330
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chvp
force-pushed
the
feature/sanitize-submission-result
branch
from
c9b0546
to
5c2d7bf
Compare
Codecov Report
@@ Coverage Diff @@
## develop #1330 +/- ##
===========================================
+ Coverage 82.18% 83.78% +1.59%
===========================================
Files 89 89
Lines 4154 4156 +2
===========================================
+ Hits 3414 3482 +68
+ Misses 740 674 -66
|
bmesuere
requested changes
Oct 5, 2019
|
Note: we get deprecation warnings because of this but it should be fixed in the next version of |
chvp
force-pushed
the
feature/sanitize-submission-result
branch
from
1dfbd95
to
03effe1
Compare
|
I've added tests for and fixed the stripping of the content of tags in d13c4ee. It's quite hard to test this in the tests of the renderers though, since we actually want to escape most of the HTML in the JSON (e.g. in the diff table), which means the content will still be there (escaped, but otherwise unchanged). |
chvp
force-pushed
the
feature/sanitize-submission-result
branch
from
03effe1
to
d13c4ee
Compare
This reverts commit d13c4ee.
bmesuere
approved these changes
Oct 7, 2019
rien
commented
Oct 7, 2019
| "generated": "<script>alert('Your mother was a hamster and your father smelt of elderberries.')</script>" | ||
| "accepted": false, | ||
| "description": "test whether the user can XSS", | ||
| "expected": "<script>alert('Your mother was a hamster and your father smelt of elderberries.')</script><script>alert('test')</script><script>alert('test')</script><script>alert('test')</script><script>alert('test')</script><script>alert('test')</script><script>alert('test')</script><script>alert('test')</script><script>alert('test')</script><script>alert('test')</script><script>alert('test')</script><script>alert('test')</script><script>alert('test')</script><script>alert('test')</script><script>alert('test')</script><script>alert('test')</script><script>alert('test')</script><script>alert('test')</script><script>alert('test')</script><script>alert('test')</script><script>alert('test')</script><script>alert('test')</script>", |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request sanitizes submission results (i.e. we prevent additional
<script>in judge output from being executed).TODO:
Fixes #1139.