Match Loofah's API changes. #100
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Short term, reduces log noise due to deprecated constants. Long term, necessary just to keep up.
3 tasks
jrochkind
added a commit
to sciencehistory/scihist_digicoll
that referenced
this pull request
Nov 11, 2019
To get rid of annoying "warning: constant Loofah::HTML5::WhiteList is deprecated" messages rails/rails-html-sanitizer#100 Did with `bundle update --conservative rails-html-sanitizer`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Loofah revised constant names and deprecated the older constants. The resulting log noise galvanizes immediate action.
In the short term, this change removes log noise due to deprecated constants.
In long term, it's just to keep up.