Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update to ruby 3.1 #3646

Merged
merged 3 commits into from
Jun 28, 2022
Merged

Update to ruby 3.1 #3646

merged 3 commits into from
Jun 28, 2022

Conversation

chvp
Copy link
Member

@chvp chvp commented May 22, 2022 •
edited
Loading

No description provided.

@chvp chvp added chore Repository/build/dependency maintenance deploy mestra Request a deployment on mestra labels May 22, 2022
@chvp chvp temporarily deployed to mestra May 22, 2022 11:25 Inactive
@github-actions github-actions bot removed the deploy mestra Request a deployment on mestra label May 22, 2022
@chvp
Copy link
Member Author

chvp commented May 22, 2022

Matching ansible PR: https://github.com/dodona-edu/dodona-ansible/pull/145

@chvp chvp marked this pull request as ready for review May 22, 2022 12:14
@chvp chvp requested a review from a team as a code owner May 22, 2022 12:14
@chvp chvp requested review from bmesuere and jorg-vr and removed request for a team May 22, 2022 12:14
jorg-vr
jorg-vr approved these changes May 24, 2022
View reviewed changes
Copy link
Contributor

@jorg-vr jorg-vr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not sure of I am one 100% fan of the new syntax, but I'll get used to it :)

@bmesuere
Copy link
Member

bmesuere commented May 24, 2022 •
edited by chvp
Loading

I am not sure of I am one 100% fan of the new syntax, but I'll get used to it :)

I agree, I'm more fond of explicit naming, but I guess rubocop has a good reason to do it this way.

bmesuere
bmesuere approved these changes May 24, 2022
View reviewed changes
Copy link
Member

@bmesuere bmesuere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I of course agree with bumping this. Can we coordinate this easily or do we need to wait till after the exams (and coordinate this with the yearly server upgrade)

@chvp
Copy link
Member Author

chvp commented May 24, 2022

I of course agree with bumping this. Can we coordinate this easily or do we need to wait till after the exams (and coordinate this with the yearly server upgrade)

Coordination is quite easy. We can pre-install the new ruby version on our servers while keeping things running with the old version. A passenger restart (which happens as part of the deployment process) then switches to the new version.

@chvp
Copy link
Member Author

chvp commented May 24, 2022

I'm pretty sure the style is configurable. If we prefer writing the keyword/hash args explicitely, we can probably configure it that way. This is just the default. I personally don't have a strong opinion either way.

@chvp
Copy link
Member Author

chvp commented Jun 27, 2022

I changed the style to disallow the hash shorthand syntax. Didn't like it either.

@chvp chvp force-pushed the chore/ruby-3.1 branch 2 times, most recently from b9d5ef8 to b6bcb92 Compare June 27, 2022 20:49
@chvp chvp merged commit 1b79230 into develop Jun 28, 2022
@chvp chvp deleted the chore/ruby-3.1 branch June 28, 2022 11:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bmesuere bmesuere bmesuere approved these changes

@jorg-vr jorg-vr jorg-vr approved these changes

Assignees
No one assigned
Labels
chore Repository/build/dependency maintenance
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@chvp @bmesuere @jorg-vr