Home page redesign: put most important content on top #4185
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bmesuere
requested changes
Dec 6, 2022
There was a problem hiding this comment.
I really like this change 👍
Two minor UI remarks:
- I feel that the gap between title and subtitle is a bit too large. This is most prominent in the exercise card where the info text is closer to the subtitle than the title. This is probably because you used a
<br>in combination with the bigger line height of the header tag. - Is it possible to add a slight shadow on hover?
bmesuere
requested changes
Dec 7, 2022
There was a problem hiding this comment.
The UI changes look good 👍
There's still a small issue with the wording of the progress bar tooltip: in a series of 4 exercises where 2 are correct and 2 unstarted, it now says: 2 started, 2 correct. This is confusing because the 2 started ones are the two that are correct. Also, the order should follow the order of the bar itself: correct, incorrect, not yet started.
I have no remarks about the code.
niknetniko
approved these changes
Dec 7, 2022
Co-authored-by: Niko Strijbol <strijbol.niko@gmail.com> Co-authored-by: Bart Mesuere <Bart.Mesuere@UGent.be>
|
I updated the tooltip to |
bmesuere
approved these changes
Dec 7, 2022
Co-authored-by: Bart Mesuere <Bart.Mesuere@UGent.be>
|
(maybe wait to merge this one till after the exercise filter PRs are merged and released as 6.3?) |
chvp
approved these changes
Dec 9, 2022
Co-authored-by: Charlotte Van Petegem <charlotte.vanpetegem@ugent.be>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request is a first step of the home page redesign #2882.
The goal of this step is to put the most important and actionable information on top.
Concretely we provide a clickable card to continue where you left of and up to two cards to signal upcoming deadlines.
The "jump back in card" contains either:
There are three different clickable cards designed, based on what should be shown:
Activity
Series
Course
Part of #2882