Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show and sort by popularity in activities table #4222

Merged
merged 14 commits into from
Dec 13, 2022

Conversation

jorg-vr
Copy link
Contributor

@jorg-vr jorg-vr commented Dec 8, 2022

This pull request adds the concept popularity to activities. It represent how often an activity is used, and should help users find a decent activity or their course.

The activities tables are sorted by popularity by default. (With the option to sort by name as was the old behavior).

I also introduced an extra filter to filter by popularity

image
image
image

  • Tests were added

Closes #4208 .

@jorg-vr jorg-vr added the feature New feature or request label Dec 8, 2022
@jorg-vr jorg-vr self-assigned this Dec 8, 2022
@jorg-vr jorg-vr changed the title Show popularity in activities table Show and sort by popularity in activities table Dec 8, 2022
@jorg-vr jorg-vr marked this pull request as ready for review December 8, 2022 15:17
@jorg-vr jorg-vr requested a review from a team as a code owner December 8, 2022 15:17
@jorg-vr jorg-vr requested review from niknetniko and chvp and removed request for a team December 8, 2022 15:17
Copy link
Member

@bmesuere bmesuere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😻
Is it possible to also add this as a filter?

Copy link
Member

@chvp chvp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree that it would be nice to filter by popularity.

@bmesuere bmesuere temporarily deployed to naos December 12, 2022 14:08 — with GitHub Actions Inactive
@bmesuere bmesuere temporarily deployed to naos December 13, 2022 09:47 — with GitHub Actions Inactive
@jorg-vr jorg-vr merged commit b7e0f2c into develop Dec 13, 2022
@jorg-vr jorg-vr deleted the feature/order-activities-by-popularity branch December 13, 2022 12:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Order activities by popularity
4 participants