Rename application_old and only include where relevant #4374
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jorg-vr
requested review from
bmesuere and
chvp
and removed request for
a team
bmesuere
requested changes
Jan 31, 2023
app/views/activities/show.html.erb
Outdated
| @@ -2,6 +2,7 @@ | |||
| <%= javascript_include_tag 'exercise' %> | |||
| <% if @activity.exercise? %> | |||
| <%= javascript_include_tag 'submission' %> | |||
| <%= javascript_include_tag 'ace_editor' %> | |||
There was a problem hiding this comment.
I'm not sure and it's hard to test, but exercise.ts uses the ace global which I think is defined in the ace editor file. Because the order of inclusion changed (app_old was included as the first js file) this might break in some cases. To be sure, I think it's better to add this include first here.
There was a problem hiding this comment.
Ace is only used inside a function, which is only executed upon document ready, so I don't think it matters.
But I switched the inclusion order anyway
bmesuere
approved these changes
Jan 31, 2023
chvp
approved these changes
Jan 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request renames
application_old.jstoace_editor.jsas this is the only legacy code still included.It is also no longer loaded on every page, as the code is only relevant on the detail page of an exercise, where the code editor is actually shown.
Closes #4360.