Fix SubmissionRunner ignoring errors while removing temporary directory with judge results #5429
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request removes the non-existing argument
verbose: true
from theFileUtils.remove_entry_secure
method, as it causes this method to silently ignore errors.The method FileUtils#remove_entry_secure has the following signature:
The
verbose: true
argument is actually translated to a hash, causing the parameterforce
to be truthy. Any errors thrown while removing the unwanted files, are ignored because of the last line of the method:This was hiding errors in Dolos because of this bug (see the first two commits in: dodona-edu/dolos#1413).