Overall timeout policy feature #37
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sync from origin
When HttpClientTimeout less than TimeoutOverall then HttpClientTimeout equal as TimeoutOverall. tests: HttpClientWrapperBuilder using AddJsonClient instead of a direct call AddHttpClient add 5 test cases of Overall Timeout parameter
Ceridan
suggested changes
Oct 16, 2020
src/Dodo.HttpClient.ResiliencePolicies.Tests/TimeoutPolicyTests.cs
Outdated
Show resolved
Hide resolved
timeoutOverall combines feature httpClientTimeout timeoutOverall became required tests: fixs for new changes + Should_httpClientTimeout_is_overallTimeout_with_delta_1000ms test
sync from origin
HttpClient.Timeout set in AddJsonClient method
Ceridan
suggested changes
Oct 18, 2020
src/Dodo.HttpClient.ResiliencePolicies.Tests/DSL/HttpClientWrapperBuilder.cs
Outdated
Show resolved
Hide resolved
- preserve properties order: TimeoutOverall before TimeoutPerTry - TimeoutOverallInMilliseconds set 50000 - fix spelling error
Ceridan
approved these changes
Oct 18, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
HttpClientSettings: add new optional parameter TimeoutOverall
When HttpClientTimeout less than TimeoutOverall then HttpClientTimeout equal as TimeoutOverall.
tests: HttpClientWrapperBuilder using AddJsonClient instead of a direct call AddHttpClient
add 5 test cases of Overall Timeout parameter
Issue #13