Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement DTX #65

Closed
9 tasks done
doe300 opened this issue Dec 22, 2015 · 0 comments
Closed
9 tasks done

Implement DTX #65

doe300 opened this issue Dec 22, 2015 · 0 comments
Labels
enhancement
Milestone
Version 1.0

Comments

@doe300
Copy link
Owner

doe300 commented Dec 22, 2015

Implement the use of DTX (discontinued transmission)

  • send nothing while silence (in RTP-processor)
  • on continuation of audio-stream, set marker-bit in RTP header
  • on receivers side, continue creating silence-packages (and increment sequence-number, as before)
  • on receiver side, when marker set, reset current sequence-number to received one (to sync number of "not send" and "not received" packages

Determining silence:

  • implement as Processor (automatically added, like RTP-processor?)
  • Calculate sum of absolute values / quadratic sum of samples and check for a given threshold (e.g. by converting to decibel, threshold could be configurable)
  • silence-calculation must be fast
  • add flag for silence to stream-parameters (so other processors can skip it)
  • flag is set by silence-processor on transmitting end and rtp-processor on receiving (when playing silent-package)

Silence-Handling:

  • add DTX-tag SDP media-line for SIP-configuration
  • configure Opus according to DTX enabled/disabled

See:
http://stackoverflow.com/questions/15002688/detect-sound-level-in-raw-pcm-data
https://en.wikipedia.org/wiki/Decibel#Acoustics
https://tools.ietf.org/html/rfc7587
@doe300 doe300 added this to the Version 1.0 milestone Dec 22, 2015
doe300 pushed a commit that referenced this issue Jan 21, 2016
@doe300
Implemented basic handling of DTX, see #65
0d84351 
Added clipping to the amplifier-processor
Signed-off-by:doe300 <stadeldani@web.de>
doe300 added a commit that referenced this issue Jan 21, 2016
@doe300
Added parameter to configure DTX, see #65
768fecc 
Signed-off-by:doe300
doe300 added a commit that referenced this issue Jan 21, 2016
@doe300
Added custom configuration to SIPConfiguration
d8751e3 
Added format-parameters to SupportedFormats and SDP-message
Added support for DTX to SIPConfiguration, see #65
Signed-off-by:doe300 <stadeldani@web.de>
@doe300 doe300 mentioned this issue Jan 27, 2016
Open
doe300 added a commit that referenced this issue Feb 7, 2016
@doe300
Added DTX to opus, closes #65
30598b6 
Fixed default gain for SIP-configuration
Signed-off-by:doe300 <stadeldani@web.de>
@doe300 doe300 closed this as completed Feb 7, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
Version 1.0
Development

No branches or pull requests
1 participant
@doe300