add build / test step for gradle build #6
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I think this is supposed to be "./gradlew clean check" right?
phasebash
reviewed
Feb 23, 2017
| @@ -11,10 +11,10 @@ gradle-app.setting | |||
| .gradletasknamecache | |||
|
|
|||
| # # Work around https://youtrack.jetbrains.com/issue/IDEA-116898 | |||
| gradle/wrapper/gradle-wrapper.properties | |||
| # gradle/wrapper/gradle-wrapper.properties | |||
There was a problem hiding this comment.
all stuff in ./gradle should be committed
There was a problem hiding this comment.
Yeah, IDEA wants to use gradle-all to get the src code for auto completion. not a big deal, just let it update the file and commit it.
phasebash
approved these changes
Feb 23, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a real build/test step to the Jenkinsfile. It also adds a .travis.yml to integrate with Travis. @duraz0rz, I took gradle-wrapper.properties out of .gitignore because I couldn't ./gradlew without it. I saw that you had a comment about this: https://youtrack.jetbrains.com/issue/IDEA-116898, but I didn't completely understand what that's all about. Can you give some context?