-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: remove repetitive words #3525
base: master
Are you sure you want to change the base?
Conversation
Signed-off-by: fuyangpengqi <995764973@qq.com>
Anything need I to do? If have, Please feel free to tell me. |
@@ -482,7 +482,7 @@ static int secp256k1_ecdsa_sign_inner(const secp256k1_context* ctx, secp256k1_sc | |||
break; | |||
} | |||
is_nonce_valid = secp256k1_scalar_set_b32_seckey(&non, nonce32); | |||
/* The nonce is still secret here, but it being invalid is is less likely than 1:2^255. */ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Missed this in my previous review, apologies.
We should not update any files under src/secp256k1
in our repo because this is part of a subtree. Please update this in the upstream at https://github.com/bitcoin-core/secp256k1 and we'll pick it up next time we update the subtree.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@patricklodder do you think it would be useful/appropriate to add subtree checks to the linter?
No description provided.