Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sidemenu stuck in swipe #50

Closed
fadizant opened this issue Dec 24, 2018 · 4 comments
Closed

Sidemenu stuck in swipe #50

fadizant opened this issue Dec 24, 2018 · 4 comments

Comments

@fadizant
Copy link

fadizant commented Dec 24, 2018

  • [ ✔️] I have verified there are no duplicate active or recent bugs, questions, or requests
Include the following:
  • AKSideMenu version: 1.4.2
  • Device OS version: 12.0
  • Device Name: iPhone 6s
Reproduction Steps
  1. add sidemenu using pod
  2. using storyboard like sample
  3. add rightmenu only
Expected Result

swipe and release before fully open must be close or open side menu

Actual Result

menu stuck in the middle of swiping

Tell us what could be improved:

make sidemenu full open or close depends of percentage of swipe to full open

img_1002

@fadizant
Copy link
Author

after double check, I found that if you don't set leftMenuViewController the swipe back will not work fine, any suggest to fix this issue

Thanks

@fadizant
Copy link
Author

here is the problem

func hideMenuViewControllerAnimated(_ animated: Bool) {
        let rightMenuVisible: Bool = self.rightMenuVisible

        if let visibleMenuViewController = (rightMenuVisible ? self.rightMenuViewController : self.leftMenuViewController) {
.....

I use the rightMenuViewController only so when i try to slide the menu with and release it in blow of open limit the AKSideMenu will try to hide the menu but the case is self.rightMenuVisible is false and the self.leftMenuViewController is nil so the hide function will not work in this case.

@nihasmata
Copy link

nihasmata commented Jan 3, 2019

I have the same issue ,I am using only rightMenuViewController. When i disable leftMenuViewController like below swipe is not working correctly. When i release my finger near to safe area, swipe freezes.

self.contentViewController = storyboard.instantiateViewController(withIdentifier: "contentViewController")
           //self.leftMenuViewController = storyboard.instantiateViewController(withIdentifier: "leftMenuViewController")
           self.rightMenuViewController = storyboard.instantiateViewController(withIdentifier: "rightMenuViewController")

dogo added a commit that referenced this issue Jan 6, 2019
@dogo
Copy link
Owner

dogo commented Jan 6, 2019

Thanks guys! Fixed, please update to 1.4.3
@fadizant
@nihasmata

@dogo dogo closed this as completed Jan 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants