Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

App Freeze when sideMenuController is not in hierarchy. #71

Closed
hackiftekhar opened this issue Nov 19, 2019 · 2 comments
Closed

App Freeze when sideMenuController is not in hierarchy. #71

hackiftekhar opened this issue Nov 19, 2019 · 2 comments
Assignees
Labels

Comments

@hackiftekhar
Copy link

hackiftekhar commented Nov 19, 2019

#47 is the duplicate card that hasn't been fixed yet. I cannot reopen due to insufficient permission.

Include the following:
  • AKSideMenu version: 1.4.4
  • Device OS version: 13.1
  • Device Name: iPhone 11 Pro Max (Simulator)
Reproduction Steps
  1. Create a brand new Xcode project and add AKSideMenu library.
  2. Embed ViewController in NavigationController.
  3. call self.sideMenuViewController in viewDidAppear.
Expected Result
  • If there are no side menu controller embedded then self.sideMenuViewController will return nil.
Actual Result
  • self.sideMenuViewController call stuck in an infinite loop.

Tell us what could be improved:

  • When iterator.parent is nil, both if condition fails and while loop stuck in an infinite loop. There should be a nil validation of the iterator variable in sideMenuViewController var.

Screenshot 2019-11-19 at 5 08 12 PM

dogo added a commit that referenced this issue Nov 20, 2019
App Freeze when sideMenuController is not in hierarchy. #71
Calling variable sideMenuViewController in UIViewController extension freezes the app when it is not in view hierarchy #47
@dogo
Copy link
Owner

dogo commented Nov 20, 2019

@hackiftekhar
Thanks for reporting this issue and providing useful information.
Please update to 1.4.5

@dogo dogo closed this as completed Nov 20, 2019
@dogo dogo added the bug label Nov 20, 2019
@dogo dogo self-assigned this Nov 20, 2019
@hackiftekhar
Copy link
Author

Thanks @dogo for quick action on this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants