Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Calling variable sideMenuViewController in UIViewController extension freezes the app when it is not in view heirarchy #47

Closed
1 task
gauravlnx opened this issue Oct 3, 2018 · 2 comments
Assignees
Labels

Comments

@gauravlnx
Copy link

gauravlnx commented Oct 3, 2018

  • I have verified there are no duplicate active or recent bugs, questions, or requests

If in a viewController I access the defined in the UIViewController extension, the app freezes

self.sidemenuViewController

This happens if the side menu is not in the view Heirarchy. The app goes into an infinite loop and app freezes.

Include the following:
  • AKSideMenu version: 1.0.0
  • Device OS version: 6.0
  • Device Name: iPhone 6
Reproduction Steps
  1. Load SideMenu inside a Navigation stack
  2. Instead of pushing a controller from the inside of the side menu, push it directly to the above navigation controller.
  3. In the controller, if the sidemenuViewController property is accessed, the app will freeze.
Expected Result

The property should return nil instead of going into an infinite while loop.

Actual Result

The app goes into an infinite while loop.

Tell us what could be improved:

@dogo
Copy link
Owner

dogo commented Oct 3, 2018

Please provide me a sample

@dogo dogo closed this as completed Jan 8, 2019
dogo added a commit that referenced this issue Nov 20, 2019
App Freeze when sideMenuController is not in hierarchy. #71
Calling variable sideMenuViewController in UIViewController extension freezes the app when it is not in view hierarchy #47
@dogo
Copy link
Owner

dogo commented Nov 20, 2019

@gauravlnx
Please update to 1.4.5

@dogo dogo self-assigned this Nov 20, 2019
@dogo dogo added the bug label Nov 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants