ref: Replace statik with Go embed #109
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
force-pushed
the
feature/goEmbed
branch
7 times, most recently
from
811981a
to
426c87d
Compare
ghost
changed the title
ghost
force-pushed
the
feature/goEmbed
branch
from
426c87d
to
bb77035
Compare
ghost
force-pushed
the
feature/goEmbed
branch
2 times, most recently
from
d0c077d
to
5c16cf2
Compare
stepanstipl
changed the title
|
Ok, I like getting rid of statik, looks simpler and certainly nicer to use Go-native feature now that it's available 🎉 🎉 , thanks @david-doit-intl! 2 minor things:
|
|
Just noticed there's already #101 by bot, perhaps we can move the whole Go 1.16 upgrade there. |
|
@stepanstipl yeah lets get 1.16 in first with the bot, then I can merge :). Will try to move rules back to top level, had some issues but will try again. |
ghost
changed the title
ghost
force-pushed
the
feature/goEmbed
branch
2 times, most recently
from
29a3a90
to
877e3d7
Compare
ghost
changed the title
ghost
force-pushed
the
feature/goEmbed
branch
2 times, most recently
from
d7f3833
to
18075e3
Compare
|
@stepanstipl updated to isolate rules to its own package pretty happy now. |
ghost
commented
Mar 1, 2021
| @@ -64,7 +65,12 @@ func TestEvalRules(t *testing.T) { | |||
| manifests = append(manifests, manifest) | |||
| } | |||
|
|
|||
| judge, err := NewRegoJudge(&RegoOpts{}) | |||
| loadedRules, err := rules.FetchRegoRules() | |||
There was a problem hiding this comment.
We should make some mock rules in a later PR
ghost
force-pushed
the
feature/goEmbed
branch
2 times, most recently
from
fb1789b
to
b87270e
Compare
Signed-off-by: david-doit-intl <david@doit-intl.com>
stepanstipl
changed the title
stepanstipl
approved these changes
Mar 1, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #107
Signed-off-by: david-doit-intl david@doit-intl.com