File collector #15
Merged
File collector #15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I like this, adding a file provider is good. |
|
LGTM, I would say about the tests should be added |
ghost
approved these changes
Jul 30, 2020
|
make sure you rebase! |
ghost
force-pushed
the
feat-file-collector
branch
2 times, most recently
from
39213ad
to
3b6664a
Compare
stepanstipl
force-pushed
the
feat-file-collector
branch
from
3b6664a
to
6e11954
Compare
|
@david-doit-intl added tests, pls. have a look 👍 |
ghost
reviewed
Jul 31, 2020
| @@ -0,0 +1,2 @@ | |||
| 🐈 | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for local file collector #6 via the
-fflag. Supports JSON and YAML manifests, flag can be repeated multiple times:Support for reading from stdin will be in a separate PR.
Should be merged after #14 .