fix: Autoscaling/v2beta1 removed in Kubernetes 1.25

[johngmyers]

Fixes #459

[stepanstipl]

Thanks @johngmyers, this looks good 👍 . Can you pls. also move the tests¹ accordingly? (and rebase on the current master if possible).

Cheers 🎉.

Footnotes

1. https://github.com/doitintl/kube-no-trouble/blob/d0ef3cbbe478d67aa1aa83a75d5c13c701a69ba0/test/rules_126_test.go#L9 ↩

[johngmyers]

@stepanstipl the git-check-commits.sh script appears to be enforcing a capitalization requirement that is not in the Conventional Commits specification and is not mentioned in README.md. The apiVersion in question is typically rendered in lower case.

[stepanstipl]

Hi @johngmyers, you're totally correct here. Do you think that for now, you can perhaps rephrase the commit? Maybe smth. like fix: Move autoscaling/v2beta1 to Kubernetes 1.25 group or similar.

On the topic of the capital letters - I guess it's a personal preference. Not a strong one, so potentially open to discussion (I simply think it doesn't matter too much). But you're right that it would be a good idea to mention this in the docs 🙏 .

[johngmyers]

@stepanstipl I changed the commit message

[stepanstipl]

Thanks, LGTM. 👍 🎉

[stepanstipl]

Oh, one more thing - sorry, I noticed only when trying to merge. Can you pls. sign the commit? ¹²

Footnotes

1. https://docs.github.com/en/authentication/managing-commit-signature-verification/about-commit-signature-verification ↩

2. https://docs.github.com/en/authentication/managing-commit-signature-verification/signing-commits ↩

[johngmyers]

@stepanstipl I'll have to create a key. This signing requirement is another thing that isn't but should be mentioned in the Development section of README.md.

[dark0dave]

@stepanstipl I'll have to create a key. This signing requirement is another thing that isn't but should be mentioned in the Development section of README.md.

@johngmyers, I will sort that out thanks! See #485

[johngmyers]

@stepanstipl commit is signed now.

[stepanstipl]

👍 thanks!