-
Notifications
You must be signed in to change notification settings - Fork 157
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Add brew installation method #501
chore: Add brew installation method #501
Conversation
Could you commit us the scripts you used to build this? I am not sure we want to publicly endorse a homebrew package we did not make. |
@dark0dave - what do you think about adding a "3rd party" section to the readme. I'm not sure we want to maintain this (and possibly many other packages/distributions), but maybe making it clear it's 3rd party effort, and linking to it would be a good compromise? (Also I believe the Homebrew formulas have to live in the HB repo 1) And thanks for making this happen @devenes Footnotes |
Sure ok, so long as we link to the source. And yes I hope my remarks make sense @devenes, thank you. |
3b908ad
to
a4829f0
Compare
a4829f0
to
577f7df
Compare
Thanks for valuable feedback @dark0dave @stepanstipl. In response to your suggestions, I edited the document to include sections for both manual and third-party methods. Additionally, I added a note for the third-party approach. For referencing the source, I used formula link. Kindly request to review these changes and share any further recommendations. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm happy with this, thanks for the changes @devenes 👍
@devenes looks like there are some trailing spaces. Would you kindly run the pre-commit and rebase? Apologies. |
def5827
to
6e8c25d
Compare
chore: Add brew installation method
6e8c25d
to
801d5d3
Compare
I apologize for that. I believe I have fixed the issue. Could you please check it? |
@devenes pre-commit passed look like we are good! |
Added brew installation method to README with reference to https://formulae.brew.sh/formula/kubent