Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Add brew installation method #501

Merged

Conversation

devenes
Copy link
Contributor

@devenes devenes commented Jun 30, 2023

Added brew installation method to README with reference to https://formulae.brew.sh/formula/kubent

@dark0dave dark0dave self-assigned this Aug 16, 2023
@dark0dave
Copy link
Collaborator

dark0dave commented Aug 17, 2023

Could you commit us the scripts you used to build this? I am not sure we want to publicly endorse a homebrew package we did not make.

@stepanstipl
Copy link
Contributor

stepanstipl commented Aug 17, 2023

@dark0dave - what do you think about adding a "3rd party" section to the readme.

I'm not sure we want to maintain this (and possibly many other packages/distributions), but maybe making it clear it's 3rd party effort, and linking to it would be a good compromise?

(Also I believe the Homebrew formulas have to live in the HB repo 1)

And thanks for making this happen @devenes

Footnotes

  1. https://github.com/Homebrew/homebrew-core/blob/055ae78415b61ecf1fa3de32b76b8a149855f903/Formula/k/kubent.rb

@dark0dave dark0dave self-requested a review August 17, 2023 09:19
@dark0dave
Copy link
Collaborator

dark0dave commented Aug 17, 2023

Sure ok, so long as we link to the source.

And yes I hope my remarks make sense @devenes, thank you.

@dark0dave dark0dave force-pushed the chore-Add-brew-installation-method branch from 3b908ad to a4829f0 Compare August 17, 2023 09:20
@devenes devenes force-pushed the chore-Add-brew-installation-method branch from a4829f0 to 577f7df Compare August 17, 2023 12:23
@devenes
Copy link
Contributor Author

devenes commented Aug 17, 2023

Thanks for valuable feedback @dark0dave @stepanstipl.

In response to your suggestions, I edited the document to include sections for both manual and third-party methods. Additionally, I added a note for the third-party approach.

For referencing the source, I used formula link. Kindly request to review these changes and share any further recommendations.

Copy link
Contributor

@stepanstipl stepanstipl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm happy with this, thanks for the changes @devenes 👍

@dark0dave
Copy link
Collaborator

dark0dave commented Aug 18, 2023

@devenes looks like there are some trailing spaces. Would you kindly run the pre-commit and rebase? Apologies.

@devenes devenes force-pushed the chore-Add-brew-installation-method branch 2 times, most recently from def5827 to 6e8c25d Compare August 18, 2023 10:01
chore: Add brew installation method
@devenes devenes force-pushed the chore-Add-brew-installation-method branch from 6e8c25d to 801d5d3 Compare August 18, 2023 10:05
@devenes
Copy link
Contributor Author

devenes commented Aug 18, 2023

I apologize for that. I believe I have fixed the issue. Could you please check it?

@dark0dave
Copy link
Collaborator

@devenes pre-commit passed look like we are good!

@dark0dave dark0dave merged commit e74bb93 into doitintl:master Aug 18, 2023
26 checks passed
@devenes devenes deleted the chore-Add-brew-installation-method branch August 18, 2023 11:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants