dep: Update autorest and solve ambiguous import isue #55
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stepanstipl
force-pushed
the
dep-autorest
branch
from
60b1c3e
to
19077cd
Compare
ghost
approved these changes
Oct 29, 2020
|
I just not sure about the generated files thats all |
As in committing these to git repo? |
|
@david-doit-intl Just thinking about this, there seem to be 3 options: a) Not using Dependabot at all -> maybe later move to a custom solution, but for now, I would prefer to try out of the box one. b) Use, but disable c) Use, and commit generated files (this PR) I'm kinda open to trying the option b) first, if you find it preferable. |
|
just for record - concern is about generated files in generate, not whether to commit or not in git -> let's discuss separately |
stepanstipl
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated autorest dependency to resolve the ambiguous import (Azure/go-autorest#528) issue and get
go mod tidyworking. Also committed generated files (we should add some check these are up-to-date) in order to makego mod tidyand Dependabot combo happy (fixes https://github.com/doitintl/kube-no-trouble/network/updates/68342830).