Added first test #9
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
removed a link to an issue
ghost
force-pushed
the
feature/tests
branch
9 times, most recently
from
c7fe29f
to
3d0f025
Compare
ghost
force-pushed
the
feature/tests
branch
2 times, most recently
from
f6f2bf6
to
a806e7b
Compare
stepanstipl
reviewed
Jul 13, 2020
There was a problem hiding this comment.
Thanks @david-doit-intl I think that's a great start 👍cheers. Some minor notes on GH actions/Makefile org below. Also, I see merging is blocked because commits are not signed 1, can you?
ghost
force-pushed
the
feature/tests
branch
2 times, most recently
from
c6234f4
to
192d2f6
Compare
Signed-off-by: david-doit-intl <david@doit-intl.com>
|
@stepanstipl all done, please review. |
|
Thanks, merged & I've made the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Will add Github Actions testing, this is just making sure you are ok with the flow.