Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Default the Helm manifest namespace to the release namespace #95

Merged
merged 1 commit into from Jan 29, 2021

Conversation

meringu
Copy link
Contributor

@meringu meringu commented Jan 28, 2021

closes: #67

@ghost ghost requested a review from stepanstipl January 28, 2021 09:10
@ghost
Copy link

ghost commented Jan 28, 2021

LGTM, if @stepanstipl could have a look and is happy we can merge.

@stepanstipl
Copy link
Contributor

stepanstipl commented Jan 28, 2021

Thanks @meringu, I think this is great! 👍 I'm reasonably confident this will work for Helm v3, as the release info is stored in the same namespace where the release is deployed.

However for v2, won't this always be the namespace where the Tiller is deployed (I think kube-system by default)?

TL;DR: You mentioned it worked in your setup in #67, were you able to test this with Helm v2?

@meringu
Copy link
Contributor Author

meringu commented Jan 28, 2021

Yes we have a very large helmv2 deployment still.

Tiller can go in any namespace, it only defaults to kube-system. This is configured with the --tiller-namespace flag. However, when you install a release you can override the namespace with the --namespace flag.

This seems to report correctly over our hundreds of helmv2 deprecation warnings. The release namespace ends up being the default namespace to deploy the resources, just like helmv3.

Copy link
Contributor

@stepanstipl stepanstipl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, thanks for confirming this, sounds good. 👍

@stepanstipl stepanstipl merged commit 9f6f733 into doitintl:master Jan 29, 2021
@meringu meringu deleted the release-default-ns branch January 29, 2021 10:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

helm deployments return undefined namespaces
2 participants