Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NonReadable must be set on write-only storage images #460

Closed
gfxstrand opened this issue Jun 28, 2018 · 4 comments
Closed

NonReadable must be set on write-only storage images #460

gfxstrand opened this issue Jun 28, 2018 · 4 comments
Labels

Comments

@gfxstrand
Copy link

When DXVK uses a write-only storage image, it needs to set the NonWriteable decoration. The Vulkan 1.1.78 spec, Appendix A, "Images and Samplers", says,

If shaderStorageImageReadWithoutFormat is not enabled and an OpTypeImage has “Image Format” operand of Unknown, any variables created with the given type must be decorated with NonReadable.

This missing decoration is causing misrendering of Skyrim on Intel. We don't support shaderStorageImageReadWithoutFormat and depend on that decoration for proper descriptor set setup. I hacked up the driver to implicitly set the decoration on all images with an unknown format and it fixes all the rendering issues in Skyrim.

Software information

Skyrim Special Edition

System information

  • GPU: Intel Skylake GT4e
  • Driver: Intel Vulkan driver, Mesa 18.1.0
@doitsujin
Copy link
Owner

doitsujin commented Jun 28, 2018

Thanks for the detailed report, c370eea should fix this - please let me know whether that works.

@MrChebik
Copy link

MrChebik commented Jun 28, 2018

Wow! Thank you, I do not know whether this fixed issues in Murdered: Soul Suspect.
But since 0.61, in game works HDAO and in some places, the game has not artifacts when the character / environment turns white gradient.

--
Amazing! This removed green dots in Skyrim SE, but I still have 4-5 fps in game.

@gfxstrand
Copy link
Author

@MrChebik I just pushed an optimization to mesa master which helps Skyrim out massively:

https://gitlab.freedesktop.org/mesa/mesa/commit/06412bfc9869247f33b6bba8e256cf33f71f6973

It's still not going to run great on a Broadwell GT2 but it'll be a lot better than it is now.

@MrChebik
Copy link

MrChebik commented Jul 2, 2018

@jekstrand Thank you! I wish you success!

--
FPS increased to 24-30, sometimes there are jerks of the image.
@jekstrand Do you get a VK_ERROR_DEVICE_LOST error after some time? In my case, it occurs after a minute of driving on a wagon.

misyltoad added a commit to misyltoad/dxvk that referenced this issue Nov 27, 2019
This game is 16:9 only and always prefers ultrawide aspect ratios if they are available for some reason.

Work around this game bug (happens on native too) by not exposing these modes for this game.

Closes doitsujin#460
misyltoad added a commit to misyltoad/dxvk that referenced this issue Dec 16, 2019
This game is 16:9 only and always prefers ultrawide aspect ratios if they are available for some reason.

Work around this game bug (happens on native too) by not exposing these modes for this game.

Closes doitsujin#460
misyltoad added a commit to misyltoad/dxvk that referenced this issue Dec 16, 2019
This game is 16:9 only and always prefers ultrawide aspect ratios if they are available for some reason.

Work around this game bug (happens on native too) by not exposing these modes for this game.

Closes doitsujin#460
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants