Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add some basic tests for env interface #12

Merged
merged 4 commits into from
Mar 11, 2022

Conversation

rejuvyesh
Copy link
Contributor

@rejuvyesh rejuvyesh commented Mar 10, 2022

I am not sure about hopper:

MethodError: no method matching initialize_walker!(::Mechanism{Float64, 23, 7, 7, 9}; z=0.25)

because it doesn't take z and rather only takes body_position and body_orientation.

Same happens with walker.

Edit I have also renamed :box to :block and fixed its use everywhere I could find.

@rejuvyesh rejuvyesh force-pushed the jkg/envtest branch 2 times, most recently from 4b67289 to 32bea1f Compare March 10, 2022 23:15
@rejuvyesh
Copy link
Contributor Author

For now, I am disabling tests for hopper, rexhopper and walker and this would be good to merge.

@codecov-commenter
Copy link

Codecov Report

Merging #12 (ab86d79) into main (0d54f76) will decrease coverage by 0.14%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #12      +/-   ##
==========================================
- Coverage   92.45%   92.31%   -0.15%     
==========================================
  Files          81       81              
  Lines        4005     3761     -244     
==========================================
- Hits         3703     3472     -231     
+ Misses        302      289      -13     
Impacted Files Coverage Δ
src/graph/entry.jl 75.00% <0.00%> (-12.50%) ⬇️
src/contacts/utilities.jl 40.00% <0.00%> (-5.46%) ⬇️
src/orientation/quaternion.jl 82.92% <0.00%> (-5.41%) ⬇️
src/orientation/mapping.jl 36.36% <0.00%> (-5.31%) ⬇️
src/joints/rotational/input.jl 42.10% <0.00%> (-1.49%) ⬇️
src/joints/joint.jl 88.88% <0.00%> (-0.51%) ⬇️
src/contacts/impact.jl 86.20% <0.00%> (-0.46%) ⬇️
src/bodies/set.jl 94.54% <0.00%> (-0.37%) ⬇️
src/mechanism/traversal.jl 95.00% <0.00%> (-0.35%) ⬇️
src/mechanism/urdf.jl 91.78% <0.00%> (-0.33%) ⬇️
... and 44 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0d54f76...ab86d79. Read the comment docs.

Copy link
Member

@janbruedigam janbruedigam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, I will create an issue for the three remaining tests.

@janbruedigam janbruedigam merged commit e96c658 into dojo-sim:main Mar 11, 2022
@rejuvyesh rejuvyesh deleted the jkg/envtest branch March 11, 2022 16:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants