This repository has been archived by the owner on Jul 30, 2018. It is now read-only.
Use new ts-loader and compatible version of webpack-contrib #234
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maier49
force-pushed
the
ignore-tests-when-not-building-tests
branch
from
6773195
to
6397491
Compare
|
@matt-gadd Is this still something we'd like to land here or should it just wait for the new build command to be completed? |
|
@maier49 lets land this 👍 |
kitsonk
approved these changes
Nov 30, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type: bug
The following has been addressed in the PR:
Description:
This updates the version of ts-loader used, and uses the new
onlyCompileBundledFilesoption. As a result, errors in test files, or other files that are not included in the resulting bundle, will not faildojo build.dojo build -wstill does not rebuild when tests are built, butdojo build -w --with-testsdoes, and since test files no longer breakdojo build -wthat's ok.The other changes are just fixing some weird formatting issues in
webpack.config.ts, and updating to the next version of webpack-contrib (not released yet) that will fix an incompatibility between the css-module-dts-loader and the new version of ts-loader.Resolves #227, #113