Better handle calling help on non existent commands #267
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JamesLMilner
changed the title
nicknisi
approved these changes
Oct 7, 2018
|
@JamesMilnerUK how does this actually look in the command output? |
agubler
reviewed
Oct 8, 2018
src/registerCommands.ts
Outdated
| @@ -217,6 +217,13 @@ export default function(yargs: Argv, groupMap: GroupMap): void { | |||
| return dojoYargs; | |||
| }, | |||
| (argv: any) => { | |||
| const isGroupCommand = argv._.length && argv._.length > 0; | |||
There was a problem hiding this comment.
just !!argv._.length or Boolean(argv._.length) would do I think
There was a problem hiding this comment.
Someone was talking about this yesterday, I think Boolean(argv._.length) is nicer but that's just me :)
|
I am reworking this to show the full main help, with an additional warning message in red, rather than just showing a simple error message. |
3 tasks
|
Closing in favour of #269 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type: bug
The following has been addressed in the PR:
prettieras per the readme code style guidelinesDescription:
At the moment the CLI returns the help template on non existent commands. This PR fixes that.
Resolves #266