Handle non existant commands when passed by the user with help flag #269
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
JamesLMilner
changed the title
bryanforbes
requested changes
Oct 29, 2018
| return `${formatHeader()} | ||
|
|
||
| ${chalk.bold( | ||
| chalk.red(`Specified command '`) + |
There was a problem hiding this comment.
I would use " instead of backticks here. I had to do a double-take to figure out what was going on.
| ${chalk.bold( | ||
| chalk.red(`Specified command '`) + | ||
| chalk.redBright(fullCommand) + | ||
| chalk.red(`' does not exist, please see available commands below.`) |
There was a problem hiding this comment.
I would do the same thing with the backticks here.
bryanforbes
approved these changes
Oct 29, 2018
agubler
approved these changes
Oct 29, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type: bug
The following has been addressed in the PR:
prettieras per the readme code style guidelinesDescription:
I had a first go at this with #267 but after speaking with @agubler felt it was better to display the actual full help with a notification that the command where help is being requested does not exist.
Resolves #266