Fix broken type exports #23
Conversation
- Fix some unexported type issues that weren't being indicated by dts-generator. They will be indicitated by the next version of dts-generator. - Update Scheduler to allow QueueItems to be scheduled directly -- this will allow subclasses to use custom QueueItems to annotate scheduled callbacks. References dojo/dom#12
| }; | ||
| } | ||
| else { | ||
| item = <QueueItem> callback; |
There was a problem hiding this comment.
There is currently no test for this condition. Please write one.
|
Hmmm...I'm not terribly happy about exposing QueueItem via |
Rather than change the public API for Scheduler#schedule, move most of its functionanlity to a protected _schedule method that accepts a QueueItem and can be overridden by subclasses. References dojo/dom#12
kfranqueiro
changed the title
|
I've merged this to master in 75704bd. I have to wonder though... is this technically a deficiency in dts-generator? I mean, the things that are exported in this changeset are really internal to the modules in question, and if you were consuming the ts files in this repository directly, I don't think there would be a problem. IIUC, the problem is that if they're not exported, dts-generator can't pick them up, but still defines other interfaces as inheriting from the unexported ones? Should it be capable of negotiating that itself, or is the limitation due to language services or something? |
|
The problem is that if an exported interface uses unexported interfaces, dts-generator won't include any of them (explicitly exported or not) in its generated file, but will appear to complete successfully. |
|
Oh, so it's not that it just exposes "holey" interfaces, it doesn't end up exposing them at all... But is that due to a limitation of its own, or due to not being able to get information from TS language services about them at all? |
|
@kfranqueiro the behaviour of dts-generator is issue #3 but also I don't know if we updated to the dts-generator that was merged on the back of SitePen/dts-generator#21 or not. |
|
dts-generator adds typings to a typings file using The change in SitePen/dts-generator#21 does something similar to tsc's |
Update Scheduler to allow QueueItems to be scheduled directly -- this will allow subclasses to use custom QueueItems to annotate scheduled callbacks.References dojo/dom#12